Make AppRegistry and Core timers Flow strict-local (#57735) - #57735
Open
rubennorte wants to merge 6 commits into
Open
Make AppRegistry and Core timers Flow strict-local (#57735)#57735rubennorte wants to merge 6 commits into
rubennorte wants to merge 6 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@rubennorte has exported this pull request. If you are a Meta employee, you can view the originating Diff in D113763781. |
|
Warning JavaScript API change detected This PR commits an update to
This change was flagged as: |
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 28, 2026
Summary: Pull Request resolved: react#57735 Upgrade `AppRegistry` (and its Flow type companion) and several Core timer modules from `flow` to `flow strict-local` with accurate types. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763781
meta-codesync
Bot
changed the title
rubennorte
force-pushed
the
export-D113763781
branch
from
July 28, 2026 17:25
55743bb to
a475e81
Compare
Summary: Upgrade the legacy native module spec files from `flow` to `flow strict-local` to enforce stricter local type checking. Loose `Object` types were replaced with the codegen-equivalent `UnsafeObject`, and `Array<any>` parameters with `Array<unknown>`, both of which are codegen-identical so the generated native interfaces are unchanged. Changelog: [Internal] Differential Revision: D113763785
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57735 Upgrade `AppRegistry` (and its Flow type companion) and several Core timer modules from `flow` to `flow strict-local` with accurate types. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763781
rubennorte
force-pushed
the
export-D113763781
branch
from
July 29, 2026 10:55
a475e81 to
213b840
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57735 Upgrade `AppRegistry` (and its Flow type companion) and several Core timer modules from `flow` to `flow strict-local` with accurate types. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763781
rubennorte
force-pushed
the
export-D113763781
branch
from
July 29, 2026 13:44
213b840 to
3ff1bc8
Compare
rubennorte
added a commit
to rubennorte/react-native
that referenced
this pull request
Jul 29, 2026
Summary: Pull Request resolved: react#57735 Upgrade `AppRegistry` (and its Flow type companion) and several Core timer modules from `flow` to `flow strict-local` with accurate types. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763781
rubennorte
force-pushed
the
export-D113763781
branch
from
July 29, 2026 15:21
3ff1bc8 to
cd0204e
Compare
Summary: Upgrade the Blob-related modules (`File`, `FileReader`, `URL`, `URLSearchParams`) from `flow` to `flow strict-local`. These expose spec-mandated getters/setters, so they opt out of the `unsafe-getters-setters` lint with a scoped `// flowlint unsafe-getters-setters:off` directive. `URL` also received small behavior-preserving refactors (local variables instead of parameter reassignment, explicit null/empty checks). Changelog: [Internal] Differential Revision: D113763778
Summary: Upgrade the StyleSheet modules from `flow` to `flow strict-local`. `processFilter` and `setNormalizedColorAlpha` required small, behavior-preserving refactors (local variables instead of reassigning function parameters, and explicit null/empty checks) to satisfy the stricter lints. Changelog: [Internal] Differential Revision: D113763790
Summary: Upgrade assorted Utilities modules from `flow` to `flow strict-local` with accurate types. `insetsDiffer` uses local variables instead of reassigning its function parameters. Behavior is unchanged. Changelog: [Internal] Differential Revision: D113763792
Summary: Upgrade assorted components from `flow` to `flow strict-local` with accurate types. `Button` replaces implicit truthiness checks with explicit comparisons that preserve the exact previous runtime behavior (no logic change). Changelog: [Internal] Differential Revision: D113763782
Summary: Pull Request resolved: react#57735 Upgrade `AppRegistry` (and its Flow type companion) and several Core timer modules from `flow` to `flow strict-local` with accurate types. Behavior is unchanged. Changelog: [Internal] Reviewed By: huntie Differential Revision: D113763781
rubennorte
force-pushed
the
export-D113763781
branch
from
July 29, 2026 16:48
cd0204e to
dc411f0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Upgrade
AppRegistry(and its Flow type companion) and several Core timer modules fromflowtoflow strict-localwith accurate types. Behavior is unchanged.Changelog: [Internal]
Reviewed By: huntie
Differential Revision: D113763781